PragmaTwice commented on code in PR #1853: URL: https://github.com/apache/kvrocks/pull/1853#discussion_r1370037277
########## src/types/redis_json.cc: ########## @@ -159,11 +159,14 @@ rocksdb::Status Json::Type(const std::string &user_key, const std::string &path, auto s = read(ns_key, &metadata, &json_val); if (!s.ok()) return s; - auto res = json_val.Type(path, results); + auto res = json_val.Type(path); + if (!res) return rocksdb::Status::InvalidArgument(res.Msg()); Review Comment: It will return error status iff the `path` is invalid. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
