PragmaTwice commented on code in PR #1852:
URL: https://github.com/apache/kvrocks/pull/1852#discussion_r1382315782
##########
src/types/redis_json.cc:
##########
@@ -91,6 +91,14 @@ rocksdb::Status Json::Info(const std::string &user_key,
JsonStorageFormat *stora
return rocksdb::Status::OK();
}
+rocksdb::Status Json::create(const std::string &ns_key, JsonMetadata metadata,
const std::string &value) {
Review Comment:
```suggestion
rocksdb::Status Json::create(const std::string &ns_key, JsonMetadata
&metadata, const std::string &value) {
```
I prefer lvalue reference or pointer since it will be changed in `write`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
