PragmaTwice commented on code in PR #1890:
URL: https://github.com/apache/kvrocks/pull/1890#discussion_r1398991434
##########
src/types/json.h:
##########
@@ -39,6 +39,11 @@
constexpr ssize_t NOT_FOUND_INDEX = -1;
constexpr ssize_t NOT_ARRAY = -2;
+enum class NumOpEnum : uint8_t {
+ Incr = 1,
+ Mul = 2,
+};
Review Comment:
I think it'd be better to put this enum inside JsonValue to avoid name
conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
