jihuayu commented on issue #124: URL: https://github.com/apache/kvrocks-controller/issues/124#issuecomment-1820873583
@git-hulk I have some question about etcd storage. In this code: When should we send "true" to `e.leaderChangeCh`, and when should we send "false"? https://github.com/apache/kvrocks-controller/blob/unstable/storage/persistence/etcd/etcd.go#L265-L277 I'm not very familiar with the Go language, but it seems like this "continue" is unnecessary. https://github.com/apache/kvrocks-controller/blob/unstable/storage/persistence/etcd/etcd.go#L271-L273 I would greatly appreciate it if you could help me answer my questions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
