mapleFU commented on code in PR #1901:
URL: https://github.com/apache/kvrocks/pull/1901#discussion_r1400663151
##########
src/commands/cmd_bit.cc:
##########
@@ -225,10 +227,145 @@ class CommandBitOp : public Commander {
BitOpFlags op_flag_;
};
+class CommandBitfield : public Commander {
+ public:
+ Status Parse(const std::vector<std::string> &args) override {
+ BitfieldOperation cmd;
+
+ read_only_ = true;
+ // BITFIELD <key> [commands...]
+ for (auto group = args.begin() + 2; group != args.end();) {
Review Comment:
Though this code LGTM, we need to check the argument of the number of
`group` doesn't visit the `args.end()`. Would you mind just using the `Parser`
here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
