wanghenshui commented on PR #1903: URL: https://github.com/apache/kvrocks/pull/1903#issuecomment-1822636615
> * https://github.com/facebook/rocksdb/blob/324453e5790f52557d02abf64a2dcadbaa54c8fa/db/forward_iterator.cc#L269 > > * https://github.com/facebook/rocksdb/blob/324453e5790f52557d02abf64a2dcadbaa54c8fa/db/db_impl/db_impl_files.cc#L707 > > > Seems this would making purge to background? Just take a quick glance seems this doesn't have some risk? yes > Also should we make this a flag? If this has bug, can we quickly turn it off? `avoid_unnecessary_blocking_io ` is global option, could not turn off online add `avoid_unnecessary_blocking_io ` is false as default if user don't care iterating with io purge, just dont change it if user iterates a lot, change config to turn it on -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
