jihuayu opened a new pull request, #1935: URL: https://github.com/apache/kvrocks/pull/1935
closed #1925 In this PR, I have added support for `KEEPTLE` and `GET` options in the `SET` command. I have also updated the `GETSET`, `SETEX`, `SETNX`, and `SETXX` commands to use the new `set` function. By the way, I have a question about when to use `std::optional<std::string>&` and when to use `std::string*`? I think that both options are equivalent, but using `std::optional<std::string>&` can help avoid null in the code. So I have used `std::optional<std::string>&` in my code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
