git-hulk commented on code in PR #2046:
URL: https://github.com/apache/kvrocks/pull/2046#discussion_r1464208605
##########
src/common/status.h:
##########
@@ -168,7 +168,7 @@ struct StringInStatusOr<T, std::enable_if_t<sizeof(T) <
sizeof(std::string)>> :
StringInStatusOr(StringInStatusOr<U>&& v) : BaseType(new
std::string(*std::move(v))) {} // NOLINT
template <typename U, typename
std::enable_if_t<!StringInStatusOr<U>::inplace, int> = 0>
StringInStatusOr(StringInStatusOr<U>&& v) // NOLINT
- : BaseType((typename StringInStatusOr<U>::BaseType &&)(std::move(v))) {}
+ : BaseType((typename StringInStatusOr<U>::BaseType&&)(std::move(v))) {}
Review Comment:
This was caused by clang-format-16 behaving differently from
clang-format-14, that said clang-format-16 will remove the space between the
type and &&, but clang-format-14 won't do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
