enjoy-binbin commented on code in PR #2055:
URL: https://github.com/apache/kvrocks/pull/2055#discussion_r1467734188
##########
src/commands/cmd_geo.cc:
##########
@@ -604,6 +624,8 @@ class CommandGeoSearchStore : public CommandGeoSearch {
return Status::OK();
}
+ static std::vector<CommandKeyRange> Range(const std::vector<std::string>
&args) { return {{1, 1, 1}, {2, 2, 1}}; }
Review Comment:
yes, this will work too, personally i want to separate them (more explicit?)
but i am ok with both of them, i can change it if you ask
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
