git-hulk commented on code in PR #2205:
URL: https://github.com/apache/kvrocks/pull/2205#discussion_r1543965597
##########
src/search/ir.h:
##########
@@ -22,33 +22,49 @@
#include <fmt/format.h>
+#include <initializer_list>
#include <limits>
#include <memory>
#include <optional>
#include <string>
+#include <type_traits>
#include <utility>
#include <variant>
#include <vector>
#include "fmt/core.h"
+#include "ir_iterator.h"
#include "string_util.h"
+#include "type_util.h"
// kqir stands for Kvorcks Query Intermediate Representation
namespace kqir {
struct Node {
virtual std::string Dump() const = 0;
+ virtual std::string_view Name() const = 0;
+ virtual std::string Content() const { return {}; }
Review Comment:
Not sure if my understanding is correct:
`Content` should be always overridden by the leaf node and `ChildBegin` and
`ChildEnd` for the non-leaf node like SELECT and HASTAG query?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
