zjregee commented on code in PR #2228:
URL: https://github.com/apache/kvrocks/pull/2228#discussion_r1555539427
##########
src/types/redis_json.cc:
##########
@@ -548,6 +548,66 @@ std::vector<rocksdb::Status> Json::MGet(const
std::vector<std::string> &user_key
return statuses;
}
+rocksdb::Status Json::MSet(const std::vector<std::string> &user_keys, const
std::vector<std::string> &paths,
+ const std::vector<std::string> &values) {
+ std::optional<MultiLockGuard> guard;
Review Comment:
Yes, this is an unnecessary expression, thank you very much for your
suggestion, I will remove the optional.
I originally used optional here just because I noticed that it was used in
the string.mset implementation, but in fact it was because of the possibility
of not locking in string.mset. So there is no need to use optional in json.mset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
