PragmaTwice commented on code in PR #2236:
URL: https://github.com/apache/kvrocks/pull/2236#discussion_r1561008469
##########
src/commands/scan_base.h:
##########
@@ -79,6 +85,38 @@ class CommandScanBase : public Commander {
return redis::Array(list);
}
+ static Status ParseScanParameters(const std::vector<std::string> &args,
ScanParameters *params) {
+ for (size_t i = 2; i < args.size(); i = i + 2) {
Review Comment:
Could you implement this function via `CommandParser`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
