PragmaTwice commented on code in PR #2238:
URL: https://github.com/apache/kvrocks/pull/2238#discussion_r1561062160
##########
src/storage/redis_db.cc:
##########
@@ -708,7 +708,7 @@ rocksdb::Status Database::typeInternal(const Slice &key,
RedisType *type) {
return rocksdb::Status::OK();
}
-rocksdb::Status Database::Move(const std::string &key, const std::string
&new_key, bool nx, bool *ret,
+rocksdb::Status Database::Move(const std::string &key, const std::string
&new_key, bool nx, bool delete_old, bool *ret,
Review Comment:
We can rename it to `Copy`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
