git-hulk commented on code in PR #2244:
URL: https://github.com/apache/kvrocks/pull/2244#discussion_r1563456569


##########
src/cluster/cluster.cc:
##########
@@ -469,6 +469,52 @@ Status Cluster::GetClusterNodes(std::string *nodes_str) {
   return Status::OK();
 }
 
+Status Cluster::GetReplicas(const std::string &node_id, std::string 
*replicas_str) {

Review Comment:
   Can use the StatusOr here:
   ```C++
   StatusOr<std::string> Cluster::GetReplicas(const std::string &node_id) {
   
    ...
    return replicas_desc;
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to