PragmaTwice commented on code in PR #2236:
URL: https://github.com/apache/kvrocks/pull/2236#discussion_r1563690381
##########
src/commands/scan_base.h:
##########
@@ -31,28 +32,33 @@ inline constexpr const char *kCursorPrefix = "_";
class CommandScanBase : public Commander {
public:
- Status ParseMatchAndCountParam(const std::string &type, std::string value) {
- if (type == "match") {
- prefix_ = std::move(value);
- if (!prefix_.empty() && prefix_[prefix_.size() - 1] == '*') {
- prefix_ = prefix_.substr(0, prefix_.size() - 1);
- return Status::OK();
- }
-
- return {Status::RedisParseErr, "only keys prefix match was supported"};
- } else if (type == "count") {
- auto parse_result = ParseInt<int>(value, 10);
- if (!parse_result) {
- return {Status::RedisParseErr, "count param should be type int"};
- }
-
- limit_ = *parse_result;
- if (limit_ <= 0) {
- return {Status::RedisParseErr, errInvalidSyntax};
+ Status Parse(const std::vector<std::string> &args) override {
+ CommandParser parser(args, 1);
+ if (util::ToLower(args[0]) != "scan") {
+ key_ = GET_OR_RET(parser.TakeStr());
Review Comment:
This should be only in `CommandSubkeyScanBase`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
