PragmaTwice commented on code in PR #2242:
URL: https://github.com/apache/kvrocks/pull/2242#discussion_r1563965514
##########
src/server/server.cc:
##########
@@ -845,14 +846,17 @@ void Server::GetRocksDBInfo(std::string *info) {
db->GetAggregatedIntProperty("rocksdb.compaction-pending",
&compaction_pending);
db->GetAggregatedIntProperty("rocksdb.num-live-versions",
&num_live_versions);
+ // All column families share the same block cache, so it's good to count a
single one.
+ auto cf_handle = storage->GetCFHandle(engine::kSubkeyColumnFamilyName);
+ db->GetIntProperty(cf_handle, "rocksdb.block-cache-usage",
&block_cache_usage);
+ string_stream << "block_cache_usage:" << block_cache_usage << "\r\n";
Review Comment:
I think it should be after the `# RocksDB` line, isn‘t it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
