PragmaTwice commented on code in PR #2262:
URL: https://github.com/apache/kvrocks/pull/2262#discussion_r1589939284
##########
src/storage/redis_db.cc:
##########
@@ -951,7 +953,10 @@ rocksdb::Status Database::Sort(const RedisType &type,
const std::string &key, co
redis::List list_db(storage_, namespace_);
list_db.Trim(args.storekey, -1, 0);
uint64_t new_size = 0;
- list_db.Push(args.storekey, std::vector<Slice>(store_elems.cbegin(),
store_elems.cend()), false, &new_size);
+ list_db.Push(
+ args.storekey,
+ std::vector<Slice>(std::make_move_iterator(store_elems.cbegin()),
std::make_move_iterator(store_elems.cend())),
Review Comment:
The value type is Slice here, so we don't need to use move iterator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
