raffertyyu commented on code in PR #2303:
URL: https://github.com/apache/kvrocks/pull/2303#discussion_r1593753518
##########
src/search/executors/filter_executor.h:
##########
@@ -100,6 +100,9 @@ struct QueryExprEvaluator {
return l > r;
case NumericCompareExpr::GET:
return l >= r;
+ default:
+ assert(false);
+ return false;
Review Comment:
Actually all branches are covered here, but gcc thought it should have a
default branch to cover any unforeseen case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]