LindaSummer commented on issue #2550:
URL: https://github.com/apache/kvrocks/issues/2550#issuecomment-2376445039
Hi @Beihao-Zhou ,
Sorry to bother you.
Please correct me if my analysis is incorrect. 😊
The GitHub Action's log is `Layer: 4 Frequency: 458 Expected:
411.52266242457773`.
If I understand correctly, this expected value should be
$(3{^-4}-3{^-5})*50000=411.5226337448559$.
Since we use a random seed from `random_device`.
https://github.com/apache/kvrocks/blob/f2bc224bc342f7e2b679cb2dc79d7a31067643ca/src/search/hnsw_indexer.cc#L180-L181
We can't reproduce the same generation sequence and in my knowledge the
generation result may have unexpectable skew.
Could I use a fixed rand seed for unit test startup initialization to solve
this issue?
I think it will improve the reproducing ability for test cases.
Best Regards,
Edward
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
