LindaSummer commented on code in PR #2557:
URL: https://github.com/apache/kvrocks/pull/2557#discussion_r1777890834
##########
src/search/hnsw_indexer.h:
##########
@@ -92,7 +92,10 @@ struct HnswIndex {
std::mt19937 generator;
double m_level_normalization_factor;
- HnswIndex(const SearchKey& search_key, HnswVectorFieldMetadata* vector,
engine::Storage* storage);
+ HnswIndex(const SearchKey& search_key, HnswVectorFieldMetadata* vector,
engine::Storage* storage,
+ std::random_device::result_type seed);
+ HnswIndex(const SearchKey& search_key, HnswVectorFieldMetadata* vector,
engine::Storage* storage)
+ : HnswIndex(search_key, vector, storage, std::random_device()()) {}
Review Comment:
Hi @Beihao-Zhou ,
I have updated related constructors. 😊
Best Regards,
Edward
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
