PragmaTwice commented on code in PR #2713: URL: https://github.com/apache/kvrocks/pull/2713#discussion_r1905494457
########## tests/gocase/util/math.go: ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package util + +import "cmp" + +// Min returns the smaller of two values. +func Min[T cmp.Ordered](a, b T) T { Review Comment: Not a golang expert. I asked ChatGPT and it gave me the code below. You can give a try : ) ```go package main import ( "fmt" "golang.org/x/exp/constraints" ) // Max returns the maximum of two values. func Max[T constraints.Ordered](a, b T) T { if a > b { return a } return b } func main() { // Test with integers fmt.Println(Max(3, 7)) // Output: 7 // Test with floats fmt.Println(Max(3.14, 2.71)) // Output: 3.14 // Test with strings fmt.Println(Max("apple", "banana")) // Output: banana } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
