chakkk309 commented on code in PR #3312: URL: https://github.com/apache/kvrocks/pull/3312#discussion_r2925251701
########## src/commands/error_constants.h: ########## @@ -54,4 +54,7 @@ inline constexpr const char *errParsingNumkeys = "error parsing numkeys"; inline constexpr const char *errNumkeysMustBePositive = "numkeys need to be a positive integer"; inline constexpr const char *errWrongKeyword = "wrong keyword"; inline constexpr const char *errInvalidRankValue = "rank needs to be non-negative"; +inline constexpr const char *errLowCutQuantileRange = "low cut quantile must be between 0 and 1"; Review Comment: Thanks for the feedback, I tested on Redis and got those results: ``` > redis-cli -p 6380 --raw TDIGEST.TRIMMED_MEAN n nan 0.9 ERR T-Digest: error parsing low_cut_percentile > redis-cli -p 6380 --raw TDIGEST.TRIMMED_MEAN n 0.1 nan ERR T-Digest: error parsing high_cut_percentile > redis-cli -p 6380 --raw TDIGEST.TRIMMED_MEAN n -0.1 0.9 ERR T-Digest: low_cut_percentile and high_cut_percentile should be in [0,1] > redis-cli -p 6380 --raw TDIGEST.TRIMMED_MEAN n 0.9 0.1 ERR T-Digest: low_cut_percentile should be lower than high_cut_percentile ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
