[ 
https://issues.apache.org/jira/browse/KYLIN-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15127791#comment-15127791
 ] 

Shaofeng SHI commented on KYLIN-955:
------------------------------------

Hi John, from the patch I see that the method JobEngineConfig 
.getHadoopJobConfFilePath accepts two parameters now, but in 
HiveColumnCardinalityJob, it uses 
"jobEngineConfig.getHadoopJobConfFilePath(null)" which only passes one 
parameter, does your IDE report a compile error there? 

> HiveColumnCardinalityJob didn't use configurations in conf/kylin_job_conf.xml
> -----------------------------------------------------------------------------
>
>                 Key: KYLIN-955
>                 URL: https://issues.apache.org/jira/browse/KYLIN-955
>             Project: Kylin
>          Issue Type: Bug
>          Components: Job Engine
>    Affects Versions: v0.7.2, v0.7.1
>            Reporter: Shaofeng SHI
>            Assignee: zhaoyunjiong
>            Priority: Minor
>              Labels: newbie
>             Fix For: Backlog
>
>         Attachments: KYLIN-955-1.x-staging.patch, 
> KYLIN-955-2.x-staging.patch, KYLIN-955.patch
>
>
> We defined some customized configurations in conf/kylin_job_conf.xml, while 
> the cardinality job doesn't use those configurations;
> This job's behavior need be consistent with others like the cubing jobs;



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to