[
https://issues.apache.org/jira/browse/KYLIN-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15295383#comment-15295383
]
liyang commented on KYLIN-1721:
-------------------------------
Nice catch!! This is critical. Need to patch 1.5.2 release.
> KylinConfigExt lost base properties when store into file
> --------------------------------------------------------
>
> Key: KYLIN-1721
> URL: https://issues.apache.org/jira/browse/KYLIN-1721
> Project: Kylin
> Issue Type: Bug
> Components: Metadata
> Affects Versions: v1.5.2
> Reporter: Yerui Sun
> Assignee: Yerui Sun
> Priority: Critical
> Fix For: v1.5.2
>
>
> KylinConfigExt overrides getAllProperties() to merge the base properties and
> the override properties into one Properties, which used to get config or
> write into file.
> In the following code, super properties stored in Properties.*defaults*,
> which will *NOT* written out by store() method, quoted from [java
> document|https://docs.oracle.com/javase/7/docs/api/java/util/Properties.html#store(java.io.OutputStream,%20java.lang.String)].
> That will lost super properties when store KylinConfigExt into file.
> {code}
> protected Properties getAllProperties() {
> Properties result = new Properties(super.getAllProperties());
> result.putAll(overrides);
> return result;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
