[ https://issues.apache.org/jira/browse/KYLIN-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385185#comment-15385185 ]
Ma Gang commented on KYLIN-1827: -------------------------------- Hi Shaofeng, any concern on the patch? at least the bug in getProjectName/getDeployEnvName method in CubingJob should be fixed, those methods just return a constant string. > Send mail notification when runtime exception throws during build/merge cube > ---------------------------------------------------------------------------- > > Key: KYLIN-1827 > URL: https://issues.apache.org/jira/browse/KYLIN-1827 > Project: Kylin > Issue Type: Improvement > Components: Job Engine > Affects Versions: v1.5.1, v1.5.2 > Reporter: Ma Gang > Assignee: Ma Gang > Fix For: v1.6.0 > > Attachments: fix_send_notification.patch, > fix_send_notification_2.patch > > > Currently mail notification is only sent in the onExecuteFinished() method, > but no notification will be sent when RuntimeException throws, that may cause > user miss some important job build failure, especially for some automation > merge jobs. Sometimes job state update fails(the hbase metastore is > unavailable in a short time), it will make the job always look like in a > running state, but actually it is failed, should send mail to notify user. -- This message was sent by Atlassian JIRA (v6.3.4#6332)