[ 
https://issues.apache.org/jira/browse/KYLIN-1855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391004#comment-15391004
 ] 

liyang commented on KYLIN-1855:
-------------------------------

Query must always return correct result. That's for sure. Also it is the 
CubeDesc that finally define the cube, not the model. I agree with Yanghong.

[~yaho], I merged the patch with an additional code reformat commit. Your code 
style config seems not identical with what's stated on "How to contribute". 
Please have a check.
[~mahongbin], the checkstyle "AvoidStaticImport" does not work with 'mvn clean 
package'? I don't see it report error on Yanghong's commit. Why?

> Should exclude those joins in whose related lookup tables no dimensions are 
> used in cube
> ----------------------------------------------------------------------------------------
>
>                 Key: KYLIN-1855
>                 URL: https://issues.apache.org/jira/browse/KYLIN-1855
>             Project: Kylin
>          Issue Type: Improvement
>            Reporter: Zhong Yanghong
>            Assignee: Zhong Yanghong
>         Attachments: exclude_unused_joins.patch
>
>
> A cube is based on a model in which a star schema is defined. In some cases, 
> the cube utilizes only a few lookup tables rather than all. In this case, 
> when creating the sql for the flat table, those lookup tables should not be 
> included. Otherwise, it will confuse users when query. If users do query 
> according to the definition of the flat table, error of no realization will 
> occur due to lack of the related join.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to