[ 
https://issues.apache.org/jira/browse/KYLIN-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15460754#comment-15460754
 ] 

kangkaisen commented on KYLIN-1992:
-----------------------------------

Thanks for your comment.

Firstly, this minor issue could be reproduced stably. we could make a 
continuous and successful query go through while loop, in the meantime,we could 
make a failed query with syntax error . In this way, we will get wrong 
`Realization Names` in the failed query log and the  `Realization Names`  
belong to the successful query.

Secondly, most of failed query had this issue  failed because the sql parsed 
wrong and didn't start to scan HBase.

Thirdly, I am sorry for I did't  consider the integration query tests.

> Clear ThreadLocal Contexts when query failed before scaning HBase
> -----------------------------------------------------------------
>
>                 Key: KYLIN-1992
>                 URL: https://issues.apache.org/jira/browse/KYLIN-1992
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: kangkaisen
>            Assignee: kangkaisen
>            Priority: Minor
>         Attachments: KYLIN-1992.patch
>
>
> currently, we call `OLAPContext.clearThreadLocalContexts()` function before 
> scaning HBase.
> if query failed before scaning HBase, we would get wrong `realization` of the 
> query in the log possibly.
> Because the thread pool of Tomcat multiplexed the thread and didn't clear 
> ThreadLocal variable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to