[ https://issues.apache.org/jira/browse/KYLIN-1908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15481606#comment-15481606 ]
kangkaisen commented on KYLIN-1908: ----------------------------------- OK, I know. I have close the PR. > Collect Metrics to JMX > ---------------------- > > Key: KYLIN-1908 > URL: https://issues.apache.org/jira/browse/KYLIN-1908 > Project: Kylin > Issue Type: New Feature > Components: Tools, Build and Test > Affects Versions: v1.5.2 > Reporter: kangkaisen > Assignee: kangkaisen > Fix For: v1.5.4 > > Attachments: KYLIN-1908.patch, QueryMetrics.java > > > As we all known, some performance metrics is important for enterprise > applications. so we should support to collect metrics to JMX in Kylin. > The method I have done is As shown below: > 1. use `org.apache.hadoop.metrics2` as the metrics collection framework. > 2. define MBean Class for the metrics that we need to collect. > 3. update metrics in right place. > The questions I have: > 1. can I depend on `org.apache.hadoop.metrics2` directly? > 2. how do you think about my method? -- This message was sent by Atlassian JIRA (v6.3.4#6332)