[ https://issues.apache.org/jira/browse/KYLIN-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090514#comment-16090514 ]
liyang commented on KYLIN-2718: ------------------------------- I see the introduction of a log of the combination... which makes things complicated. Concerning it is really an edge case, I don't feel it worth that complexity. Why don't we just detect the long overflows and throw an exception or cap at Long.MAX_VALUE? Just want to keep things as simple as possible. > overflow when calculating combination amount based on static rules > ------------------------------------------------------------------ > > Key: KYLIN-2718 > URL: https://issues.apache.org/jira/browse/KYLIN-2718 > Project: Kylin > Issue Type: Bug > Components: Metadata > Affects Versions: all > Reporter: Zhong Yanghong > Assignee: Zhong Yanghong > Fix For: v2.0.0 > > Attachments: APACHE-KYLIN-2718.patch > > > In extreme case, value of *combination* will exceed Long.MAX_VALUE leading to > the validation noneffective. -- This message was sent by Atlassian JIRA (v6.4.14#64029)