[
https://issues.apache.org/jira/browse/KYLIN-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168893#comment-16168893
]
Dong Li edited comment on KYLIN-2871 at 9/16/17 11:36 AM:
----------------------------------------------------------
Thanks Shengping. Please go ahead to submit a patch.
was (Author: lidong_sjtu):
Thanks Shengping. Please go ahead to submit a patch.
> Ineffective null check in SegmentRange
> --------------------------------------
>
> Key: KYLIN-2871
> URL: https://issues.apache.org/jira/browse/KYLIN-2871
> Project: Kylin
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Shengping
> Priority: Minor
>
> For Endpoint#getComparator() :
> {code}
> } else if (b.isMax) {
> return a.isMax ? 0 : -1;
> } else {
> if (a == null || b == null)
> throw new IllegalStateException();
> {code}
> The null check should be placed in the front.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
