[ 
https://issues.apache.org/jira/browse/KYLIN-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

hedong.wang updated KYLIN-2907:
-------------------------------
    Description: 
The function isPositiveShort does not seem correct, located in the 
core-common/src/main/java/org/apache/kylin/common/util/BytesUtil.java.
0xFFFF7000 should be 0xFFFF8000?!
code:
public static boolean isPositiveShort(int i) {
        return (i & 0xFFFF7000) == 0;
}

  was:
The function isPositiveShort does not seem correct, located in 
thecore-common/src/main/java/org/apache/kylin/common/util/BytesUtil.java.
0xFFFF7000 should be 0xFFFF8000?!
code:
public static boolean isPositiveShort(int i) {
        return (i & 0xFFFF7000) == 0;
}


> Check if a number is a positive integer 
> ----------------------------------------
>
>                 Key: KYLIN-2907
>                 URL: https://issues.apache.org/jira/browse/KYLIN-2907
>             Project: Kylin
>          Issue Type: Bug
>          Components: Tools, Build and Test
>    Affects Versions: v2.1.0
>         Environment: centos64
>            Reporter: hedong.wang
>            Assignee: hongbin ma
>              Labels: patch
>             Fix For: Future
>
>   Original Estimate: 6h
>  Remaining Estimate: 6h
>
> The function isPositiveShort does not seem correct, located in the 
> core-common/src/main/java/org/apache/kylin/common/util/BytesUtil.java.
> 0xFFFF7000 should be 0xFFFF8000?!
> code:
> public static boolean isPositiveShort(int i) {
>       return (i & 0xFFFF7000) == 0;
> }



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to