[ 
https://issues.apache.org/jira/browse/KYLIN-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16213638#comment-16213638
 ] 

liyang edited comment on KYLIN-2944 at 10/21/17 1:34 AM:
---------------------------------------------------------

Hold on a bit... by creating new objects, the increased GC may impact 
performance at all places where the serializers are used. Have we tested the 
performance difference at least?

I recall a benchmark where reusing ArrayList vs new ArrayList on every record 
yields 5% performance difference.


was (Author: liyang.g...@gmail.com):
Hold on a bit... by creating new objects, the increased GC may impact 
performance at all places where the serializers are used. Have we tested the 
performance difference at least?

> HLLCSerializer, RawSerializer, PercentileSerializer returns shared object in 
> serialize()
> ----------------------------------------------------------------------------------------
>
>                 Key: KYLIN-2944
>                 URL: https://issues.apache.org/jira/browse/KYLIN-2944
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: Shaofeng SHI
>            Assignee: Shaofeng SHI
>             Fix For: v2.2.0
>
>
> This is a bug, which causing incorrect query result. See more in KYLIN-2926



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to