[ https://issues.apache.org/jira/browse/KYLIN-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272777#comment-16272777 ]
Billy Liu commented on KYLIN-3072: ---------------------------------- Thanks [~peng.jianhua], could you add unit test for this update also? > Fix the regular expression in function 'removeCommentInSql' > ----------------------------------------------------------- > > Key: KYLIN-3072 > URL: https://issues.apache.org/jira/browse/KYLIN-3072 > Project: Kylin > Issue Type: Bug > Components: Query Engine > Reporter: peng.jianhua > Assignee: peng.jianhua > Attachments: > 0001-KYLIN-3072-Fix-the-regular-expression-in-function-re.patch, 01.png, > 02.PNG > > > select * from kylin_sales /*comments--comments*/ > we should remove comments like '/*comments*/' first,then remove comments like > '--comments' , or the sql above will have an exception. > please refer to 01.png. > if we exchange the sequence of this two comment patterns,we will get 02.png. -- This message was sent by Atlassian JIRA (v6.4.14#64029)