[ 
https://issues.apache.org/jira/browse/KYLIN-3004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dong Li resolved KYLIN-3004.
----------------------------
       Resolution: Fixed
    Fix Version/s: v2.3.0

Thanks Julian. Patch merged to master branch, see commit 
https://github.com/apache/kylin/commit/07142889d4423b3211be625eceb8fd093fd34a22

I also append a code review commit, please have a look:
https://github.com/apache/kylin/commit/b55f4967067f0ecc056d58c9ba081e496f0d2b9e

> Delete cube segment validation
> ------------------------------
>
>                 Key: KYLIN-3004
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3004
>             Project: Kylin
>          Issue Type: Bug
>          Components: REST Service
>    Affects Versions: v2.1.0
>            Reporter: Pan, Julian
>            Assignee: Pan, Julian
>             Fix For: v2.3.0
>
>         Attachments: KYLIN_3004.patch, KYLIN_3004.patch
>
>
> In version 2.1, kylin allow hole between segment.
> But currently, there is validation for delete segment.
> Here is the code in CubeService:
>  if (!segmentName.equals(cube.getSegments().get(0).getName())
>                 && 
> !segmentName.equals(cube.getSegments().get(cube.getSegments().size() - 
> 1).getName())) {
>             throw new 
> BadRequestException(String.format(msg.getDELETE_NOT_FIRST_LAST_SEG(), 
> segmentName));
>         }
> Does it make sense? Should we remove the limit?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to