[jira] [Comment Edited] (KYLIN-3204) Unclosed resources in JdbcExplorer#evalQueryMetadata

[Kaige Liu (JIRA)]

    [ 
https://issues.apache.org/jira/browse/KYLIN-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16341979#comment-16341979
 ] 

 Kaige Liu edited comment on KYLIN-3204 at 1/27/18 5:39 AM:
------------------------------------------------------------

Hi [~yuzhih...@gmail.com], I think con and rs will be closed properly.

 
{quote}DatabaseMetaData dbmd = con.getMetaData();
 ResultSet rs = dbmd.getColumns(null, tmpDatabase, tmpView, null);
 ColumnDesc[] result = extractColumnFromMeta(rs);
 *DBUtils.closeQuietly(rs);*
 *DBUtils.closeQuietly(con);*
{quote}


was (Author: liukaige):
Hi [~yuzhih...@gmail.com], I think con and rs will be close properly.

 
{quote}DatabaseMetaData dbmd = con.getMetaData();
ResultSet rs = dbmd.getColumns(null, tmpDatabase, tmpView, null);
ColumnDesc[] result = extractColumnFromMeta(rs);
*DBUtils.closeQuietly(rs);*
*DBUtils.closeQuietly(con);*
{quote}

> Unclosed resources in JdbcExplorer#evalQueryMetadata
> ----------------------------------------------------
>
>                 Key: KYLIN-3204
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3204
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Major
>
> {code}
>             Connection con = SqlUtil.getConnection(dbconf);
>             DatabaseMetaData dbmd = con.getMetaData();
>             ResultSet rs = dbmd.getColumns(null, tmpDatabase, tmpView, null);
> {code}
> con and rs should be closed upon return.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)