[ 
https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374345#comment-16374345
 ] 

Zhixiong Chen commented on KYLIN-2884:
--------------------------------------

Hi,[~julianpan]

You don't need combine 2 commits.

But could you put 'loadDetail(cube)' into  function  'startDeleteSegment' like 
cube's merge action?

Because it can reduce the call of api.

 

> Add delete segment function for portal
> --------------------------------------
>
>                 Key: KYLIN-2884
>                 URL: https://issues.apache.org/jira/browse/KYLIN-2884
>             Project: Kylin
>          Issue Type: Improvement
>          Components: Web 
>            Reporter: Pan, Julian
>            Assignee: Pan, Julian
>            Priority: Major
>             Fix For: v2.3.0
>
>         Attachments: KYLIN-2884.patch, KYLIN-2884.patch, KYLIN-2884.patch, 
> KYLIN-2884.patch, screenshot-1.png, screenshot-2.png
>
>
> Kylin restful already support delete segment function. Could we add a action 
> button for front-end to user?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to