[ 
https://issues.apache.org/jira/browse/KYLIN-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375468#comment-16375468
 ] 

Zhong Yanghong commented on KYLIN-3265:
---------------------------------------

Hi [~Shaofengshi], this patch looks good for me, except two concerns:
* By add {{jobSearchMode}} in {{JobListRequest}}, will this impact the interface
* 
{color:#f79232}JobService.JobSearchMode.valueOf(jobRequest.getJobSearchMode()){color}
 may return null.

> Add "jobSearchMode" as a condition to "/kylin/jobs" API
> -------------------------------------------------------
>
>                 Key: KYLIN-3265
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3265
>             Project: Kylin
>          Issue Type: Improvement
>          Components: REST Service
>    Affects Versions: v2.3.0
>            Reporter: Shaofeng SHI
>            Priority: Major
>         Attachments: KYLIN-3265.master.001.patch
>
>
> In kylin 2.3, the "/kylin/jobs" API will return both cubing job and 
> checkpoint job together, this changed the API's behavior as there isn't 
> checkpoint job before. We should keep the api only return cubing jobs to be 
> compitable as before, and extend the API to add another condition 
> 'jobSearchMode' to determine which kind of job should be returned. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to