[
https://issues.apache.org/jira/browse/KYLIN-3430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16532833#comment-16532833
]
Shaofeng SHI commented on KYLIN-3430:
-------------------------------------
Hi Temple,
I did a quick review, here are several comments:
1) the patch has many line break changes, these are unnecessary, please check
your git or editor configuration.
2) global dictionary is a part of metadata, so the cleanup should be in
MetadataCleanupJob, not StorageCleanupJob;
3) it seems there is no check about whether a dictionary has reference or not,
this is incorrect. please check the MetadataCleanupJob as a reference.
Please double check and update a new patch. Thanks!
> Global Dictionary Cleanup
> -------------------------
>
> Key: KYLIN-3430
> URL: https://issues.apache.org/jira/browse/KYLIN-3430
> Project: Kylin
> Issue Type: Improvement
> Components: Tools, Build and Test
> Affects Versions: v2.1.0, v2.2.0, v2.3.0, v2.3.1, v2.4.0
> Reporter: Temple Zhou
> Assignee: Temple Zhou
> Priority: Major
> Attachments: KYLIN-3430.master.001.patch
>
>
> I had run "{{./bin/metastore.sh clean --delete true" to cleanup my Kylin
> metadata, but, after that, the Global Dictionary still exists in my HDFS and
> the size of directory "/kylin_metadata/resources/GlobalDict/dict" hasn't
> shrunk.}}
>
> {{BTW: I'm very sure that there are redundant Global Dictionaries.}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
