[jira] [Commented] (KYLIN-3475) Make calcite case handling and quoting method more configurable.

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/KYLIN-3475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16561767#comment-16561767
 ] 

ASF GitHub Bot commented on KYLIN-3475:
---------------------------------------

coveralls commented on issue #180: feat(query): Make calcite connection is more 
configurable. #KYLIN-3475
URL: https://github.com/apache/kylin/pull/180#issuecomment-408825381
 
 
   ## Pull Request Test Coverage Report for [Build 
3368](https://coveralls.io/builds/18225439)
   
   * **4** of **5**   **(80.0%)**  changed or added relevant lines in **2** 
files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage increased (+**0.2%**) to **24.726%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | 
[core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java](https://coveralls.io/builds/18225439/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigBase.java#L1239)
 | 3 | 4 | 75.0%
   <!-- | **Total:** | **4** | **5** | **80.0%** | -->
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/18225439/badge)](https://coveralls.io/builds/18225439)
 |
   | :-- | --: |
   | Change from base [Build 3367](https://coveralls.io/builds/18221018): |  
0.2% |
   | Covered Lines: | 15573 |
   | Relevant Lines: | 62983 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Make calcite case handling and quoting method more configurable.
> ----------------------------------------------------------------
>
>                 Key: KYLIN-3475
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3475
>             Project: Kylin
>          Issue Type: Improvement
>          Components: Query Engine
>            Reporter: Ian Hu
>            Priority: Major
>
> >> Do you know whether Calcite supports that? If Calcite already supports it 
> >> with some parameter, Kylin can expose that as a configuration. Yes, 
> >> Calcite support to customize some sql handle feature by connection 
> >> properties. We can customize it by provide an Properties when use jdbc's 
> >> DriverManager.getConnection(url, extraProperties). Here is my commit (with 
> >> UT) to achieve this 
> >> [https://github.com/ian4hu/kylin/commit/88ee638fb4c8b55b089294107ad361ec3fc6dae9]
> >>   For short lookup see QueryConnection.getConnection(project)@ 
> >> [https://github.com/apache/kylin/blob/25b300c1f654561e561565ebf35c4e0e93ae0a04/query/src/main/java/org/apache/kylin/query/QueryConnection.java#L51]
> >>   the key is the info variable.
>  
> Background (from mailing list 
> [http://mail-archives.apache.org/mod_mbox/kylin-dev//201807.mbox/%3C4247fe2a.634d.164e995a707.Coremail.hu2008yinxiang%40163.com%3E]
>  ):
> We use kylin in our BI system as a sub-query engine. we met some problems in 
> our use case like bellow.
>  # Our visual design tool use source table schema as metadata, and the source 
> table column is lower case or mixed case, and visual tool generate SQL for 
> kylin query.
>  # Kylin execute sql and return result
>  # we use a parser to parse result and assembly it to entities (like ORM 
> engine did)
> but the problem is that kylin now always casting the column to UPPER case, 
> that break our parser and whe can not change that behavior by configure 
> kylin. like "select 1 as value_ALIAS" we always get the column named 
> "VALUE_ALIAS" instead of "value_ALIAS" from Kylin.
>  
> although we can use 'select 1 as "value_ALIAS"' (with double-qouted alias) 
> and it will be better if we can configure the quoting method.
>  
> I would like contribute features to make the query engine is more flexible
>  # First of all, make the case handling and quoting method is configurable by 
> kylin.properties, that a global configuration.
>  # Second make case handling and quoting method available by JDBC connection 
> url parameters or connection properties by 
> DriverManager.getConnection(url-with-parameters, extra-properties)
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)