[
https://issues.apache.org/jira/browse/KYLIN-3496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16627295#comment-16627295
]
ASF GitHub Bot commented on KYLIN-3496:
---------------------------------------
codecov-io commented on issue #255: KYLIN-3496 Make calcite extras props
available in JDBC Driver
URL: https://github.com/apache/kylin/pull/255#issuecomment-424331758
# [Codecov](https://codecov.io/gh/apache/kylin/pull/255?src=pr&el=h1) Report
> Merging [#255](https://codecov.io/gh/apache/kylin/pull/255?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/kylin/commit/34fd447c2f8b1852c530168e344d24f6efce4a3c?src=pr&el=desc)
will **increase** coverage by `<.01%`.
> The diff coverage is `55.88%`.
[](https://codecov.io/gh/apache/kylin/pull/255?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #255 +/- ##
============================================
+ Coverage 21.11% 21.12% +<.01%
- Complexity 4404 4407 +3
============================================
Files 1087 1087
Lines 69878 69910 +32
Branches 10103 10109 +6
============================================
+ Hits 14756 14768 +12
- Misses 53723 53739 +16
- Partials 1399 1403 +4
```
| [Impacted
Files](https://codecov.io/gh/apache/kylin/pull/255?src=pr&el=tree) | Coverage Δ
| Complexity Δ | |
|---|---|---|---|
|
[...org/apache/kylin/common/debug/BackdoorToggles.java](https://codecov.io/gh/apache/kylin/pull/255/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9kZWJ1Zy9CYWNrZG9vclRvZ2dsZXMuamF2YQ==)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...c/main/java/org/apache/kylin/jdbc/KylinClient.java](https://codecov.io/gh/apache/kylin/pull/255/diff?src=pr&el=tree#diff-amRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vamRiYy9LeWxpbkNsaWVudC5qYXZh)
| `68.34% <100%> (+0.5%)` | `34 <0> (+1)` | :arrow_up: |
|
[...bc/src/main/java/org/apache/kylin/jdbc/Driver.java](https://codecov.io/gh/apache/kylin/pull/255/diff?src=pr&el=tree#diff-amRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vamRiYy9Ecml2ZXIuamF2YQ==)
| `64.28% <100%> (+2.74%)` | `6 <1> (ø)` | :arrow_down: |
|
[...n/java/org/apache/kylin/query/QueryConnection.java](https://codecov.io/gh/apache/kylin/pull/255/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L1F1ZXJ5Q29ubmVjdGlvbi5qYXZh)
| `83.33% <100%> (+0.98%)` | `3 <0> (ø)` | :arrow_down: |
|
[...ain/java/org/apache/kylin/jdbc/KylinResultSet.java](https://codecov.io/gh/apache/kylin/pull/255/diff?src=pr&el=tree#diff-amRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vamRiYy9LeWxpblJlc3VsdFNldC5qYXZh)
| `87.5% <88.88%> (+0.54%)` | `9 <4> (+4)` | :arrow_up: |
|
[...ylin/job/impl/threadpool/DefaultFetcherRunner.java](https://codecov.io/gh/apache/kylin/pull/255/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdEZldGNoZXJSdW5uZXIuamF2YQ==)
| `68.18% <0%> (-4.55%)` | `9% <0%> (-1%)` | |
|
[...g/apache/kylin/source/datagen/ColumnGenerator.java](https://codecov.io/gh/apache/kylin/pull/255/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vQ29sdW1uR2VuZXJhdG9yLmphdmE=)
| `70.94% <0%> (-1.36%)` | `8% <0%> (ø)` | |
|
[...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/255/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh)
| `69.3% <0%> (-0.92%)` | `7% <0%> (ø)` | |
|
[...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/255/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh)
| `81.74% <0%> (-0.8%)` | `17% <0%> (-1%)` | |
|
[...lin/dict/lookup/cache/RocksDBLookupTableCache.java](https://codecov.io/gh/apache/kylin/pull/255/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGVDYWNoZS5qYXZh)
| `76.16% <0%> (-0.52%)` | `27% <0%> (ø)` | |
| ... and [2
more](https://codecov.io/gh/apache/kylin/pull/255/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/kylin/pull/255?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/kylin/pull/255?src=pr&el=footer). Last
update
[34fd447...2db8f2b](https://codecov.io/gh/apache/kylin/pull/255?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Make calcite extras props available in JDBC Driver
> --------------------------------------------------
>
> Key: KYLIN-3496
> URL: https://issues.apache.org/jira/browse/KYLIN-3496
> Project: Kylin
> Issue Type: Improvement
> Components: Driver - JDBC, Query Engine
> Reporter: Ian Hu
> Assignee: Ian Hu
> Priority: Minor
> Labels: features
> Fix For: v2.6.0
>
>
> Like #KYLIN-3475 , calcite can be configured in the server by
> `kylin.properties`, while the JDBC Driver is closer with the real query sql
> generation, and if calcite can be configured by jdbc client there would be
> more flexable to various situation. Like quoting as mysql or use
> mysql-specified SQL grammer.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
