[
https://issues.apache.org/jira/browse/KYLIN-3594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16632871#comment-16632871
]
ASF GitHub Bot commented on KYLIN-3594:
---------------------------------------
codecov-io commented on issue #268: KYLIN-3594 Obey JDBC standard
URL: https://github.com/apache/kylin/pull/268#issuecomment-425625134
# [Codecov](https://codecov.io/gh/apache/kylin/pull/268?src=pr&el=h1) Report
> Merging [#268](https://codecov.io/gh/apache/kylin/pull/268?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/kylin/commit/10587a65fe0552179a5c8a6e1151686ce1c8a135?src=pr&el=desc)
will **decrease** coverage by `<.01%`.
> The diff coverage is `42.85%`.
[](https://codecov.io/gh/apache/kylin/pull/268?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #268 +/- ##
============================================
- Coverage 21.16% 21.15% -0.01%
- Complexity 4405 4406 +1
============================================
Files 1086 1086
Lines 69745 69750 +5
Branches 10088 10088
============================================
- Hits 14761 14758 -3
- Misses 53586 53591 +5
- Partials 1398 1401 +3
```
| [Impacted
Files](https://codecov.io/gh/apache/kylin/pull/268?src=pr&el=tree) | Coverage Δ
| Complexity Δ | |
|---|---|---|---|
|
[...va/org/apache/kylin/rest/service/QueryService.java](https://codecov.io/gh/apache/kylin/pull/268/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9RdWVyeVNlcnZpY2UuamF2YQ==)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...in/java/org/apache/kylin/query/util/QueryUtil.java](https://codecov.io/gh/apache/kylin/pull/268/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvUXVlcnlVdGlsLmphdmE=)
| `61.33% <60%> (-0.64%)` | `19 <1> (+1)` | |
|
[.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/268/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=)
| `63.84% <0%> (-2.31%)` | `0% <0%> (ø)` | |
|
[...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/268/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh)
| `69.6% <0%> (-0.61%)` | `7% <0%> (ø)` | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/kylin/pull/268?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/kylin/pull/268?src=pr&el=footer). Last
update
[10587a6...1708a23](https://codecov.io/gh/apache/kylin/pull/268?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Select with Catalog fails
> -------------------------
>
> Key: KYLIN-3594
> URL: https://issues.apache.org/jira/browse/KYLIN-3594
> Project: Kylin
> Issue Type: Bug
> Reporter: Hosur Narahari
> Assignee: XiaoXiang Yu
> Priority: Major
>
> By using DatabaseMetaData if we get catalog using getCatalogs() method, it
> return value "defaultCatalog". It returns actual hive schema when we execute
> getSchemas().
> According to JDBC contract, catalog.schema.table should be valid from clause
> and many query layers use that. But kylin fails when we execute that query.
> I've tried to write sample code piece for that below.
>
> _DatabaseMetaData db = conn.getMetaData();_
> _ResultSet catalogSet = db.getCatalogs();_
> _String catalog = "";_
> _if(catalogSet.next()) {_
> _catalog = catalogSet.getString("TABLE_CAT");_
> _}_
> _ResultSet schemaSet = db.getSchemas();_
> _String schema = "";_
> _if(schemaSet.next()) {_
> _schema = schemaSet.getString("TABLE_SCHEM");_
> _}_
> _StringBuilder sb = new StringBuilder("SELECT * FROM ");_
> _if(!catalog.isEmpty()) {_
> _sb.append(catalog + ".");_
> _}_
> _if(!schema.isEmpty()) {_
> _sb.append(schema + ".");_
> _}_
> _sb.append("kylin_sales limit 10");_
> _String query = sb.toString();_
> _Statement stat = conn.createStatement();_
> _ResultSet rs = stat.executeQuery(query);_
> _while(rs.next()) {_
> _System.out.println(rs.getObject("trans_id"));_
> _}_
> In short, the above snippet is executing the query,
> _select * from defaultCatalog.DEFAULT.kylin_sales._
>
> Same thing happens even with different schemas if we have like,
> _select * from defaultCatalog.test.kylin_sales_ also fails.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
