[
https://issues.apache.org/jira/browse/KYLIN-3602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633007#comment-16633007
]
ASF GitHub Bot commented on KYLIN-3602:
---------------------------------------
codecov-io commented on issue #277: KYLIN-3602 Enable more checkstyle rules
URL: https://github.com/apache/kylin/pull/277#issuecomment-425644108
# [Codecov](https://codecov.io/gh/apache/kylin/pull/277?src=pr&el=h1) Report
> Merging [#277](https://codecov.io/gh/apache/kylin/pull/277?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/kylin/commit/bd8961c884cdc8ec5a9903a1d5a317bb626a2dff?src=pr&el=desc)
will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/kylin/pull/277?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #277 +/- ##
============================================
+ Coverage 21.14% 21.15% +0.01%
- Complexity 4405 4406 +1
============================================
Files 1086 1086
Lines 69802 69802
Branches 10110 10110
============================================
+ Hits 14759 14768 +9
+ Misses 53642 53637 -5
+ Partials 1401 1397 -4
```
| [Impacted
Files](https://codecov.io/gh/apache/kylin/pull/277?src=pr&el=tree) | Coverage Δ
| Complexity Δ | |
|---|---|---|---|
|
[...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/277/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh)
| `70.21% <0%> (+0.6%)` | `7% <0%> (ø)` | :arrow_down: |
|
[...g/apache/kylin/source/datagen/ColumnGenerator.java](https://codecov.io/gh/apache/kylin/pull/277/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vQ29sdW1uR2VuZXJhdG9yLmphdmE=)
| `72.29% <0%> (+1.35%)` | `8% <0%> (ø)` | :arrow_down: |
|
[.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/277/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=)
| `66.15% <0%> (+2.3%)` | `0% <0%> (ø)` | :arrow_down: |
|
[...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/277/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==)
| `78.37% <0%> (+5.4%)` | `6% <0%> (+1%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/kylin/pull/277?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/kylin/pull/277?src=pr&el=footer). Last
update
[bd8961c...fefc0ec](https://codecov.io/gh/apache/kylin/pull/277?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Enable more checkstyle rules
> ----------------------------
>
> Key: KYLIN-3602
> URL: https://issues.apache.org/jira/browse/KYLIN-3602
> Project: Kylin
> Issue Type: Improvement
> Components: Others
> Reporter: Yichen Zhou
> Priority: Major
> Fix For: v2.6.0
>
> Attachments: checkstyle-aggregate.html
>
>
> The checkstyle rules of kylin are too weak. We need to reinfore them to
> achieve better code quality.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
