[ 
https://issues.apache.org/jira/browse/KYLIN-3632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652979#comment-16652979
 ] 

ASF GitHub Bot commented on KYLIN-3632:
---------------------------------------

allenma commented on a change in pull request #290: KYLIN-3632 Add 
configuration that can switch on/off preparedStatement cache
URL: https://github.com/apache/kylin/pull/290#discussion_r225784650
 
 

 ##########
 File path: 
core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
 ##########
 @@ -1457,6 +1457,10 @@ public int getQueryMaxCacheStatementInstancePerKey() {
         return 
Integer.parseInt(this.getOptional("kylin.query.statement-cache-max-num-per-key",
 String.valueOf(50)));
     }
 
+    public boolean isQueryPreparedStatementCacheEnable() {
+        return 
Boolean.parseBoolean(this.getOptional("kylin.query.statement-cache-enabled", 
"false"));
 
 Review comment:
   Sure

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add configuration that can switch on/off preparedStatement cache in Kylin 
> server
> --------------------------------------------------------------------------------
>
>                 Key: KYLIN-3632
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3632
>             Project: Kylin
>          Issue Type: Improvement
>          Components: Query Engine
>            Reporter: Ma Gang
>            Assignee: Ma Gang
>            Priority: Minor
>             Fix For: v2.5.1
>
>
> From Kylin 2.5 we introduce preparedStatement cache feature, it can be turn 
> on/off for each request by adding a new field "enableStatementCache" in the 
> query request, by default it is on. We need to add a switch in server level, 
> the preparedStatement cache can take effective only when the switch is on, by 
> default, it will be set to false.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to