codecov-io commented on issue #301: KYLIN-3633 Avoid potential dead lock when building global dictionary URL: https://github.com/apache/kylin/pull/301#issuecomment-431662469 # [Codecov](https://codecov.io/gh/apache/kylin/pull/301?src=pr&el=h1) Report > Merging [#301](https://codecov.io/gh/apache/kylin/pull/301?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/c87856da8551b035a084c3e51aafe123f6845e6e?src=pr&el=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `25%`. [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/301/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/301?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #301 +/- ## =========================================== - Coverage 21.32% 21.3% -0.02% + Complexity 4447 4444 -3 =========================================== Files 1088 1088 Lines 69989 70004 +15 Branches 10111 10111 =========================================== - Hits 14926 14916 -10 - Misses 53664 53685 +21 - Partials 1399 1403 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/301?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...org/apache/kylin/dict/GlobalDictionaryBuilder.java](https://codecov.io/gh/apache/kylin/pull/301/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L0dsb2JhbERpY3Rpb25hcnlCdWlsZGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ylin/dict/global/SegmentAppendTrieDictBuilder.java](https://codecov.io/gh/apache/kylin/pull/301/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2dsb2JhbC9TZWdtZW50QXBwZW5kVHJpZURpY3RCdWlsZGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ava/org/apache/kylin/dict/DictionaryGenerator.java](https://codecov.io/gh/apache/kylin/pull/301/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L0RpY3Rpb25hcnlHZW5lcmF0b3IuamF2YQ==) | `54.45% <31.25%> (-5.55%)` | `10 <0> (ø)` | | | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/301/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0%> (-5.41%)` | `6% <0%> (-1%)` | | | [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/301/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `35.71% <0%> (-4.77%)` | `5% <0%> (-1%)` | | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/301/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0%> (-2.31%)` | `0% <0%> (ø)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/301/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0%> (-0.92%)` | `7% <0%> (ø)` | | | [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/301/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh) | `81.74% <0%> (-0.8%)` | `17% <0%> (-1%)` | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/301?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/301?src=pr&el=footer). Last update [c87856d...5af90f3](https://codecov.io/gh/apache/kylin/pull/301?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services