codecov-io commented on issue #303: KYLIN-3597 Refactor methods to reduce Cognitive Complexity URL: https://github.com/apache/kylin/pull/303#issuecomment-431667369 # [Codecov](https://codecov.io/gh/apache/kylin/pull/303?src=pr&el=h1) Report > Merging [#303](https://codecov.io/gh/apache/kylin/pull/303?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/c87856da8551b035a084c3e51aafe123f6845e6e?src=pr&el=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `41.79%`. [](https://codecov.io/gh/apache/kylin/pull/303?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #303 +/- ## ============================================ - Coverage 21.32% 21.32% -0.01% - Complexity 4447 4448 +1 ============================================ Files 1088 1088 Lines 69989 69995 +6 Branches 10111 10104 -7 ============================================ - Hits 14926 14923 -3 - Misses 53664 53671 +7 - Partials 1399 1401 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/303?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...in/storage/hbase/util/GridTableHBaseBenchmark.java](https://codecov.io/gh/apache/kylin/pull/303/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS91dGlsL0dyaWRUYWJsZUhCYXNlQmVuY2htYXJrLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...c/main/java/org/apache/kylin/cube/CubeManager.java](https://codecov.io/gh/apache/kylin/pull/303/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVNYW5hZ2VyLmphdmE=) | `40.39% <47.45%> (+0.68%)` | `44 <7> (+2)` | :arrow_up: | | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/303/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0%> (-5.41%)` | `6% <0%> (-1%)` | | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/303/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0%> (-2.31%)` | `0% <0%> (ø)` | | | [...g/apache/kylin/source/datagen/ColumnGenerator.java](https://codecov.io/gh/apache/kylin/pull/303/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vQ29sdW1uR2VuZXJhdG9yLmphdmE=) | `70.94% <0%> (-1.36%)` | `8% <0%> (ø)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/303/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0%> (-0.92%)` | `7% <0%> (ø)` | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/303?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/303?src=pr&el=footer). Last update [c87856d...1f54214](https://codecov.io/gh/apache/kylin/pull/303?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
