[
https://issues.apache.org/jira/browse/KYLIN-3552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665091#comment-16665091
]
ASF GitHub Bot commented on KYLIN-3552:
---------------------------------------
coveralls edited a comment on issue #312: KYLIN-3552 Data Source SDK to ingest
data from different JDBC sources
URL: https://github.com/apache/kylin/pull/312#issuecomment-432892756
## Pull Request Test Coverage Report for [Build
3813](https://coveralls.io/builds/19739855)
* **839** of **1332** **(62.99%)** changed or added relevant lines in
**40** files are covered.
* **17** unchanged lines in **2** files lost coverage.
* Overall coverage increased (+**0.7%**) to **24.039%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
|
[datasource-sdk/src/main/java/org/apache/kylin/sdk/datasource/framework/AdaptorFactory.java](https://coveralls.io/builds/19739855/source?filename=datasource-sdk%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsdk%2Fdatasource%2Fframework%2FAdaptorFactory.java#L23)
| 2 | 3 | 66.67%
|
[datasource-sdk/src/main/java/org/apache/kylin/sdk/datasource/framework/conv/ParamNodeParser.java](https://coveralls.io/builds/19739855/source?filename=datasource-sdk%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsdk%2Fdatasource%2Fframework%2Fconv%2FParamNodeParser.java#L27)
| 10 | 11 | 90.91%
|
[query/src/main/java/org/apache/kylin/query/adhoc/PushDownRunnerJdbcImpl.java](https://coveralls.io/builds/19739855/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Fadhoc%2FPushDownRunnerJdbcImpl.java#L36)
| 0 | 1 | 0.0%
|
[query/src/main/java/org/apache/kylin/query/util/PushDownUtil.java](https://coveralls.io/builds/19739855/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Futil%2FPushDownUtil.java#L116)
| 0 | 1 | 0.0%
|
[source-jdbc/src/main/java/org/apache/kylin/source/jdbc/extensible/JdbcHiveMRInput.java](https://coveralls.io/builds/19739855/source?filename=source-jdbc%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fjdbc%2Fextensible%2FJdbcHiveMRInput.java#L99)
| 44 | 45 | 97.78%
|
[source-jdbc/src/main/java/org/apache/kylin/source/jdbc/extensible/JdbcTable.java](https://coveralls.io/builds/19739855/source?filename=source-jdbc%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fjdbc%2Fextensible%2FJdbcTable.java#L65)
| 12 | 13 | 92.31%
|
[source-kafka/src/main/java/org/apache/kylin/source/kafka/KafkaSource.java](https://coveralls.io/builds/19739855/source?filename=source-kafka%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fkafka%2FKafkaSource.java#L246)
| 0 | 1 | 0.0%
|
[core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java](https://coveralls.io/builds/19739855/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigBase.java#L749)
| 0 | 2 | 0.0%
|
[datasource-sdk/src/main/java/org/apache/kylin/sdk/datasource/framework/conv/DefaultConfiguer.java](https://coveralls.io/builds/19739855/source?filename=datasource-sdk%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsdk%2Fdatasource%2Fframework%2Fconv%2FDefaultConfiguer.java#L84)
| 38 | 40 | 95.0%
|
[source-jdbc/src/main/java/org/apache/kylin/source/jdbc/JdbcExplorer.java](https://coveralls.io/builds/19739855/source?filename=source-jdbc%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fjdbc%2FJdbcExplorer.java#L281)
| 0 | 2 | 0.0%
<!-- | **Total:** | **839** | **1332** | **62.99%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
|
[core-metadata/src/main/java/org/apache/kylin/source/datagen/ColumnGenerator.java](https://coveralls.io/builds/19739855/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fdatagen%2FColumnGenerator.java#L319)
| 1 | 81.08% |
|
[source-hive/src/main/java/org/apache/kylin/source/hive/DBConnConf.java](https://coveralls.io/builds/19739855/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FDBConnConf.java#L36)
| 16 | 0.0% |
<!-- | **Total:** | **17** | | -->
| Totals | [](https://coveralls.io/builds/19739855)
|
| :-- | --: |
| Change from base [Build 3810](https://coveralls.io/builds/19711495): |
0.7% |
| Covered Lines: | 17150 |
| Relevant Lines: | 71341 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Data Source SDK to ingest data from different JDBC sources
> ----------------------------------------------------------
>
> Key: KYLIN-3552
> URL: https://issues.apache.org/jira/browse/KYLIN-3552
> Project: Kylin
> Issue Type: New Feature
> Components: Query Engine, RDBMS Source
> Reporter: youcheng.zhang
> Assignee: youcheng.zhang
> Priority: Major
> Fix For: v2.6.0
>
> Attachments: test_evidence_datasource.docx
>
>
> Kylin already supports JDBC source, but it takes much efforts to develop an
> implementation to a new source engine, like supporting metadata sync, cube
> build and query pushdown. It’s mainly because the SQL dialects and jdbc
> implementations between source engines are quite different.
> We propose to develop a data source sdk, which provides APIs to help
> developers handle these dialect differences and easily implement an adaptor
> for one source engine. With this SDK, users can achieve followings from a
> JDBC source:
> # synchronize metadata and data from jdbc source.
> # Build cube from jdbc source.
> # query pushdown to jdbc source engine when cube is unmatched.Â
> The SDK will define some interfaces of adaptors. To implement a new source,
> developers only need to implement an adaptor for the source.
> To keep compatibly, we will keep the existing JDBC source module, and
> implement a new JDBC source module as the caller of the SDK. Besides, we will
> also provide a pushdown implementation class as the caller of SDK for
> pushdown scenarios.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
