[ 
https://issues.apache.org/jira/browse/KYLIN-3631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691919#comment-16691919
 ] 

ASF GitHub Bot commented on KYLIN-3631:
---------------------------------------

whuwb commented on a change in pull request #350: Fix issue : KYLIN-3631
URL: https://github.com/apache/kylin/pull/350#discussion_r234681139
 
 

 ##########
 File path: 
core-cube/src/test/java/org/apache/kylin/cube/cuboid/CuboidSchedulerTest.java
 ##########
 @@ -118,8 +118,13 @@ private void testSpanningAndGetParent(CuboidScheduler 
scheduler, CubeDesc cube,
         }
 
         long[] spanningsArray = Longs.toArray(totalSpanning);
-        Arrays.sort(spanningsArray);
-        Arrays.sort(expectChildren);
+
+        /*
+            According to issue : 
https://issues.apache.org/jira/browse/KYLIN-3631
 
 Review comment:
   Sure

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Utilize Arrays#parallelSort for better performance
> --------------------------------------------------
>
>                 Key: KYLIN-3631
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3631
>             Project: Kylin
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Wu Bin
>            Priority: Minor
>             Fix For: v2.6.0
>
>
> Arrays#parallelSort was introduced since Java 1.8
> We can utilize Arrays#parallelSort to achieve better performance.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to