[
https://issues.apache.org/jira/browse/KYLIN-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16868502#comment-16868502
]
ASF GitHub Bot commented on KYLIN-4044:
---------------------------------------
hit-lacus commented on pull request #703: Revert "#KYLIN-4044, upgrade curator
dependency version"
URL: https://github.com/apache/kylin/pull/703
This reverts commit 970899011211b285b78cfc3a63ac5025436ddb59.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> CuratorScheduler may throw NPE when init service Cache
> ------------------------------------------------------
>
> Key: KYLIN-4044
> URL: https://issues.apache.org/jira/browse/KYLIN-4044
> Project: Kylin
> Issue Type: Bug
> Affects Versions: v3.0.0
> Reporter: PENG Zhengshuai
> Assignee: PENG Zhengshuai
> Priority: Major
>
> Currently Kylin uses Curator 2.12.0 dependencies.
> There is an issue of CURATOR-452 which may affect Kylin Server Discovery.
> When kylin server starts, it will discover other kylin server nodes in ZK
> path, and then register itself to ZK path. Curator discovery and cache
> implementation will initialize the service cache and deserialize the
> ServiceInstance by * JsonInstanceSerializer* which implemented by Kylin.
> But the CURATOR-452 hasn't been back-ported to curator-2.x branch.
> This curator issue may pass a *Null* value in
> *JsonInstanceSerializer#deserialize(byte[] bytes)* and it will cause the NPE.
> Kylin now uses the zookeeper version dependency with version 3.4.13, so
> according to the curator compatibility in
> https://curator.apache.org/zk-compatibility.html#, I think it's safe to
> upgrade the Curator version to 4.0+ in Kylin
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
