Shaofeng SHI created KYLIN-4062: ----------------------------------- Summary: Too many "if else" clause in PushDownRunnerJdbcImpl#toSqlType Key: KYLIN-4062 URL: https://issues.apache.org/jira/browse/KYLIN-4062 Project: Kylin Issue Type: Improvement Components: Query Engine Reporter: Shaofeng SHI
In this method, it has 30 "if else" which is low efficient; Should use a static Hashmap, then only need 1 check. {code:java} if ("string".equalsIgnoreCase(type)) { return Types.VARCHAR; } else if ("varchar".equalsIgnoreCase(type)) { return Types.VARCHAR; } else if ("char".equalsIgnoreCase(type)) { return Types.CHAR; } else if ...{code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)