[ https://issues.apache.org/jira/browse/KYLIN-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875904#comment-16875904 ]
王汝鹏 commented on KYLIN-4062: ---------------------------- Hi, Shaofeng, I can fix this. Can you assign this to me? > Too many "if else" clause in PushDownRunnerJdbcImpl#toSqlType > ------------------------------------------------------------- > > Key: KYLIN-4062 > URL: https://issues.apache.org/jira/browse/KYLIN-4062 > Project: Kylin > Issue Type: Improvement > Components: Query Engine > Reporter: Shaofeng SHI > Priority: Minor > > In this method, it has 30 "if else" which is low efficient; Should use a > static Hashmap, then only need 1 check. > > {code:java} > if ("string".equalsIgnoreCase(type)) { > return Types.VARCHAR; > } else if ("varchar".equalsIgnoreCase(type)) { > return Types.VARCHAR; > } else if ("char".equalsIgnoreCase(type)) { > return Types.CHAR; > } else if > ...{code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)